Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IGnosisSafe interface copy #102

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Remove IGnosisSafe interface copy #102

merged 1 commit into from
Oct 29, 2024

Conversation

mdehoog
Copy link
Contributor

@mdehoog mdehoog commented Oct 29, 2024

This breaks integration into https://github.com/ethereum-optimism/superchain-ops because they depend on the optimism version, and so we get errors:

Error (9553): Invalid type for argument in function call. Invalid implicit conversion from contract IGnosisSafe to contract IGnosisSafe requested.
  --> script/NestedSignFromJson.s.sol:19:14:
   |
19 |         sign(_signerSafe);
   |              ^^^^^^^^^^^

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 29, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@mdehoog mdehoog force-pushed the michael/remove-safe-interface branch from 0c53a15 to a05d260 Compare October 29, 2024 01:18
@mdehoog mdehoog merged commit 488e7a6 into main Oct 29, 2024
2 checks passed
@mdehoog mdehoog deleted the michael/remove-safe-interface branch October 29, 2024 01:20
mdehoog added a commit that referenced this pull request Oct 29, 2024
@mdehoog
Revert "Remove IGnosisSafe interface copy (#102)"
23a6ef5 
This reverts commit 488e7a6.
@mdehoog mdehoog mentioned this pull request Oct 29, 2024
Merged
mdehoog added a commit that referenced this pull request Oct 29, 2024
@mdehoog
Re-introduce Safe interface, and remove from function signatures (#104)
12afb9f 
* Remove IGnosisSafe from function signatures

* Revert "Remove IGnosisSafe interface copy (#102)"

This reverts commit 488e7a6.

* forge fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x00101010 0x00101010 0x00101010 approved these changes

@angel-ding-cb angel-ding-cb angel-ding-cb approved these changes

@stevieraykatz stevieraykatz Awaiting requested review from stevieraykatz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdehoog @cb-heimdall @0x00101010 @angel-ding-cb